madshi bug tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000180madVRbugpublic2014-03-16 04:572014-03-16 11:54
ReporterAlexFolland 
Assigned Tomadshi 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformWindows 32-bitOSWindows 7OS Version64-bit SP1
Summary0000180: madVR makes MPC-HC's "Keep aspect ratio" option fail
DescriptionI have a 256:224 video which has a 4:3 aspect ratio stream and container flag and I'd like to watch it in 256:224, but even with "Keep Aspect Ratio" off and "Use Stream Aspect Ratio" disabled in LAV Video, it plays in 4:3 with madVR. This is not the case when using EVR or its variants included with MPC-HC. I have not tried other renderers.
Steps To Reproduce-Use LAV Filters (Splitter, Video, and Audio) and madVR in MPC-HC
-Open LAV Video config and disable "Use Stream Aspect Ratio"
-In MPC-HC "View" -> "Video Frame" menu, ensure "Keep Aspect Ratio" is disabled
-Play this video: http://ilari.tasvideos.org/kirbyglitched.opus-10bit444.mkv [^]

The video will be displayed at some size other than 256x224. The expected result is that the video should be displayed at 256x224 with these 2 options disabled, assuming 100% zoom.
TagsNo tags attached.
madVR Version0.87.7
Media Player (with version info)MPC-HC 1.7.3.94
Splitter (with version info)LAV Splitter 0.61.1
Decoder (with version info)LAV Video Decoder 0.61.1
DecodingSoftware
Deinterlacingnone (progressive)
DXVA2 Scaling Activeno
Aero / Desktop CompositionOn
Problem occurs with modeall modes
GPU ManufacturerNVidia
GPU ModelGTX 690
GPU Driver Version335.23
Attached Files? file icon kirbyglitched.opus-10bit444.mkv [^] (7,599,296 bytes) 2014-03-16 04:57

- Relationships

-  Notes
(0000500)
kasper93 (reporter)
2014-03-16 05:42

I can't really say anything now, but from very quick look.
There is a code:
    if (!fCorrectAR) {
        if (CComQIPtr<IBasicVideo> pBV = m_pDXR) {
            pBV->GetVideoSize(&size.cx, &size.cy);
        }
    } else {
        if (CComQIPtr<IBasicVideo2> pBV2 = m_pDXR) {
            pBV2->GetPreferredAspectRatio(&size.cx, &size.cy);
        }
    }
and MPC-HC expect on IBasicVideo::GetVideoSize() call video frame size, but madVR always response with size of video frame after correction. I believe it was working once, because all code is there and there is some logic behind it.
(0000501)
madshi (administrator)
2014-03-16 09:09

I've tested all the various renderers in MPC-HC and here's the result on my PC:

AR enforced by:
Overlay Mixer Renderer
Video Mixing Renderer 7 (windowed)
Video Mixing Renderer 9 (windowed)
Enhanced Video Renderer
madVR

"Keep aspect ratio" works for:
Old Video Renderer
Video Mixing Renderer 7 (renderless)
Video Mixing Renderer 9 (renderless)
Enhanced Video Renderer (custom renderer)
Sync Video Renderer
Haali Video Renderer

At some point in the past madVR did allow "keep aspect ratio", but I remember there were some problems with that with DVD playback and showing menus correctly. Because of that I modified madVR's behaviour to be similar to VMR7/9 (windowed). Basically VMR7/9 (windowed) is where I got the idea from.

EVR uses totally different interfaces to handle DVD playback, because of that it can treat aspect ratio better without showing DVD menus incorrectly. It is on my to do list to make madVR behave like EVR for DVD playback. Once I've done that, I can also allow "keep aspect ratio" to work as expected again. But for now this is how it is, and I can't change it without breaking something else.
(0000502)
AlexFolland (reporter)
2014-03-16 09:15

OK!

Thanks for this list, as well. I guess it should be noted that standalone EVR does not work, unlike what my report claims. (Oops!)
(0000504)
madshi (administrator)
2014-03-16 11:53

So I'll close this one for now, cause it's not really a bug, but intended behaviour. As I said, I'll revisit this in a future version (but not soon).

- Issue History
Date Modified Username Field Change
2014-03-16 04:57 AlexFolland New Issue
2014-03-16 04:57 AlexFolland File Added: kirbyglitched.opus-10bit444.mkv
2014-03-16 05:42 kasper93 Note Added: 0000500
2014-03-16 09:09 madshi Note Added: 0000501
2014-03-16 09:09 madshi Assigned To => madshi
2014-03-16 09:09 madshi Status new => feedback
2014-03-16 09:15 AlexFolland Note Added: 0000502
2014-03-16 09:15 AlexFolland Status feedback => assigned
2014-03-16 11:53 madshi Note Added: 0000504
2014-03-16 11:54 madshi Status assigned => closed
2014-03-16 11:54 madshi Resolution open => no change required


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker