madshi bug tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000349madVRbugpublic2015-10-15 08:182015-10-19 11:14
Reporter6233638 
Assigned Tomadshi 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx64OSWindows 10 ProOS Version10.0.10240
Summary0000349: "Crop Black Bars" affects srcHeight and srcWidth
DescriptionEnabling the "Crop Black Bars" option in Zoom Control affects the srcHeight and srcWidth values used for profile selection.
Steps To ReproduceExample rule:
if (srcHeight = 576) "PAL DVD"
else "Default"

If a PAL DVD is played and it contains black bars which are cropped, the default profile will be used, not the PAL DVD profile.
Additional InformationIf one profile has "crop black bars" enabled, but the other rule has it disabled, madVR will crash.
 
Perhaps "cropHeight" and "cropWidth" may also be useful selectors?
TagsNo tags attached.
madVR Version0.89.9
Media Player (with version info)JRMC 21.0.11
Splitter (with version info)LAV Splitter 0.66.0.26
Decoder (with version info)LAV Video 0.66.0.26
DecodingDXVA2 Copyback
Deinterlacingnone (progressive)
DXVA2 Scaling Activeno
Aero / Desktop CompositionOn
Problem occurs with modeall modes
GPU ManufacturerNVidia
GPU ModelGTX 960
GPU Driver Version355.98
Attached Fileszip file icon settings.zip [^] (12,247 bytes) 2015-10-15 11:31

- Relationships

-  Notes
(0001209)
madshi (administrator)
2015-10-15 10:42

I'm not sure if this can be considered a "bug". After all, the feature "Crop Black Bars" actually does physically crop the black bars, in such a way that also luma/image upscaling etc don't even see the black bar pixels, anymore. madVR should behave almost identical to if you had a custom user encode with the black bars cropped. (Well, madVR crops only after chroma upscaling, so it's a bit different.)

Several users asked about whether the cropping would affect profiles, they wanted it and were happy about it. I suppose I could introduce new fields to give you more information, though.

How do your rules look like exactly?

The crash you reported definitely counts as a bug, of course. Can you attach a (zipped) "settings.bin" (or "HKCU\Software\madshi\madVR\Settings" export) with a rule setup that produces that crash?
(0001210)
6233638 (reporter)
2015-10-15 11:31

For different types of media, I want to use different Zoom Control settings.
With DVDs I want to clean up the edges, but I don't want to do that for non-DVD content; even non-DVD content which might be 360p. (so "less than 576p" rules don't work)
 
For scaling profiles, I can see where "cropHeight" and "cropWidth" might be useful - because the crop may end up at a size where you want to use different image doubling settings for example.
 
Zoom Control profiles seem like they need to be based on the source resolution, and not the crop resolution, because cropping can change the profile being used.
 
As above, an example would be:
 
if (srcHeight = 1080) "Blu-ray"
if (srcHeight = 480) or (srcHeight = 576) "DVD"
else "Default"
 
Where the DVD profile cleans up edges, Blu-ray will crop but preserve subtitles, and Default will ignore quick changes.
 
If the DVD profile cleans up edges, it's no longer 480/576px tall, and so it switches over to the Default profile.
 
---
 
I'll attach a settings file that crashes when you play a 576p video that requires cropping.
 
(note: I was in the middle of rebuilding all my profiles to include newer features, the rest is a bit of a mess right now)
(0001212)
madshi (administrator)
2015-10-19 11:14

The next build will have "srcWidth/Height", "croppedSrcWidth/Height" and "uncroppedSrcWidth/Height". Same with "targetWidth/Height". The "cropped" sizes are always the size you would get with "crop black bars" activated. The "uncropped" sizes are always the size you would get with "crop black bars" deactivated. The "srcWidth/Height" sizes are what you get with the actual value your settings have set for "crop black bars".

Furthermore, for all profiles which contain "zoom control", the profile rules automatically reinterpret "srcWidth/Height" as "uncroppedSrcWidth/Height".

- Issue History
Date Modified Username Field Change
2015-10-15 08:18 6233638 New Issue
2015-10-15 10:42 madshi Note Added: 0001209
2015-10-15 11:31 6233638 Note Added: 0001210
2015-10-15 11:31 6233638 File Added: settings.zip
2015-10-19 11:14 madshi Note Added: 0001212
2015-10-19 11:14 madshi Status new => closed
2015-10-19 11:14 madshi Assigned To => madshi
2015-10-19 11:14 madshi Resolution open => fixed


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker